This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Critical Bug Fix: Use AWS::S3::Object built in download_file method to avoid truncating during #reprocess! #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-nelson
changed the title
|
Thank you for catching this and the great fix. However, since Paperclip is deprecated, we are no longer accepting code changes. |
boatrite
pushed a commit
to mobiledoorman/paperclip
that referenced
this pull request
Jun 19, 2019
|
someone should take over paperclip then .. at least for bug fixes. |
|
for anyone arriving here from the paperclip docs: https://github.com/kreeti/kt-paperclip |
|
To clarify the previous comment – the fix was merged in kreeti#9 and released in https://github.com/kreeti/kt-paperclip/releases/tag/v6.2.0, so you can switch to https://rubygems.org/gems/kt-paperclip. See 15f85a8 for more info regarding the fork. |
ceneon
pushed a commit
to TurningArt/paperclip
that referenced
this pull request
Jan 19, 2021
Taken from thoughtbot#2637
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, I ran
#reprocess!and it truncated all original images on S3. The logs show that there was an error processing the image, and then the downloaded image was uploaded again.I inspected the temporary file created from the download, and it was empty, so that explains why the exceptions were thrown and why the original was truncated (Paperclip uploaded the empty image back to S3).
Switching to the AWS::S3::Object built in
download_filemethod fixes this.