Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4 support #1657

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Ruby 3.4 support #1657

wants to merge 2 commits into from

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Dec 5, 2024

  • Use a single quote instead of a backtick as an opening quote. [Feature #16495]
  • Hash#inspect rendering have been changed. [Bug #20433]

One thing to consider is if the single quote / backtick support should not be guarded by some Ruby version check. That would make it more explicit and later allowed easier removal, when Ruby <= 3.3 support is going to be removed.

The same applies to the Hashes, although this is likely good change on its own, since the Hash string representation is considered internal detail AFAIK.

voxik added 2 commits December 5, 2024 11:17
* Use a single quote instead of a backtick as an opening quote. [Feature #16495]
* Hash#inspect rendering have been changed. [Bug #20433]
@voxik voxik requested a review from matsales28 as a code owner December 5, 2024 10:24
@voxik
Copy link
Contributor Author

voxik commented Dec 5, 2024

Hm, there seems to be errors such as:

LoadError:
  cannot load such file -- mutex_m

I thought it was addressed for Rails 7.2. Anyway, updating the Rails 7.2 Gemfile.lock could help IMHO, but that should be separate ticket. I leave that to somebody else.

@voxik
Copy link
Contributor Author

voxik commented Dec 5, 2024

And Rubocop 🙈 The change was supposed to be minimalist ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant