Move to using the sqlalchemy mypy plugin #126
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that this was working due to a fluke in the way that process_gate works; specifically that it actually ignores the passed in state_machine value and fetches the one for the label.
It's been passed in; we can just use that.
This allows us to set the right return type for the underlying database util and makes handling of unknown labels in process_gate and process_action explicit (though admitedly in those cases it shouldn't ever happen).
This provides better type checking against the sqlalchemy code and allows us to remove our stubs and the 'type: ignore's which were in various places where the stubs didn't match reality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides better type checking against the sqlalchemy code and allows us to remove our stubs and the
type: ignores which were in various places where the stubs didn't match reality.Included here for now are some related refactors which this highlighted, though they should probably be hoisted to separate PRs.