Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rebuilding of data if not all shards are available #29

Closed
LeeSmet opened this issue Mar 16, 2021 · 2 comments
Closed

Allow rebuilding of data if not all shards are available #29

LeeSmet opened this issue Mar 16, 2021 · 2 comments
Assignees
@LeeSmet
Labels
type_bug Something isn't working

Comments

@LeeSmet
Copy link
Contributor

LeeSmet commented Mar 16, 2021

No description provided.

@LeeSmet LeeSmet added the type_bug Something isn't working label Mar 16, 2021
@LeeSmet LeeSmet added this to the Now milestone Mar 16, 2021
@LeeSmet LeeSmet self-assigned this Mar 16, 2021
@weynandkuijpers
Copy link

Can we add a little description to the story? :-)

LeeSmet added a commit that referenced this issue Mar 17, 2021
@LeeSmet
Fix writes if namespace is too small
dc89566 
The namespace size detection code returned a generic ZstorError, which
was later not picked up when removing the database from the list of
heatlhy ones. This caused the write to proceed, even though it
shouldn't. Ultimately this leads to missing shards in the metadata,
which then leads to retrieval failure in #29

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
@LeeSmet
Copy link
Contributor Author

LeeSmet commented Mar 17, 2021

It's not a story, its a bug since this feature is already implemented. I just observed some weird behavior and created this ticket as a reminder to self that I need to investigate that.

It actually seems that there needs to be a little bit more hardening in this code path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeeSmet LeeSmet

Labels
type_bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weynandkuijpers @LeeSmet