Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve write logic #4

Closed
LeeSmet opened this issue Dec 18, 2020 · 1 comment · Fixed by #28
Closed

Improve write logic #4

LeeSmet opened this issue Dec 18, 2020 · 1 comment · Fixed by #28
Assignees
Labels
type_feature New feature or request

Comments

@LeeSmet
Copy link
Contributor

LeeSmet commented Dec 18, 2020

Right now a backend setup is generated, and if any 1 zdb fails, the entire write fails. It should at least be possible to do a "degraded write" if at least data_shards backends are online. In this case, we should probably also mark the metadata in a separate tree as "degraded" for this file, thus knowing that it later needs to be fixed (when config changes).

While we are at it, it might also be possible to further improve the backend selection. We could generate new configs in a loop, removing backends which aren't healthy as we discover them, and remember the least degraded config in case we can't find a fully healthy one. This solution should find a fully healty setup if one is available at all given the constraints

@LeeSmet LeeSmet added the type_feature New feature or request label Dec 18, 2020
@LeeSmet LeeSmet self-assigned this Dec 18, 2020
@sasha-astiadi sasha-astiadi added this to the Next milestone Dec 29, 2020
LeeSmet added a commit that referenced this issue Mar 16, 2021
Close #4: Remove unhealthy nodes and retry config before writing

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
@LeeSmet
Copy link
Contributor Author

LeeSmet commented Mar 16, 2021

With the development of a monitoring daemon, this issue is reduced to just pruning unhealthy backends before writing to them. If a degraded write feature is needed in the future, a new tracking issue can be opened for it

@LeeSmet LeeSmet modified the milestones: Next, Now Mar 16, 2021
LeeSmet added a commit that referenced this issue Mar 16, 2021
Close #4: Remove unhealthy nodes and retry config before writing

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants