feat: rework contract billing storage #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brandonpille
reviewed
Oct 6, 2022
DylanVerstraete
changed the title
LeeSmet
requested changes
Oct 7, 2022
DylanVerstraete
requested review from
LeeSmet and
brandonpille
and removed request for
LeeSmet
brandonpille
approved these changes
Oct 11, 2022
|
@LeeSmet can you review migration as well please? |
DylanVerstraete
merged commit 668ef5f
into
feat/269-rework-pallet-smart-contract-billing
brandonpille
pushed a commit
that referenced
this pull request
Nov 14, 2022
brandonpille
pushed a commit
that referenced
this pull request
Nov 14, 2022
brandonpille
pushed a commit
that referenced
this pull request
Nov 16, 2022
brandonpille
pushed a commit
that referenced
this pull request
Nov 23, 2022
brandonpille
pushed a commit
that referenced
this pull request
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contracts will not get reinserted after a successful bill, rather it will get a index which can be calculated as following:
Now block % billing frequencyWhen a contract is created the index is generated as:
Now block - 1 % billing frequencyFor such, the offchain worker will not bill the contract in the same block it gets created.
Even if the offchain worker now fails to bill the contract, it can be billed in the next cycle. The elapsed time between the first bill (or creation) and next bill is calculated anyway.