fix: save graced contracts total amount due #631
Conversation
DylanVerstraete
requested review from
brandonpille,
renauter,
robvanmieghem and
LeeSmet
as code owners
| if matches!(contract.state, types::ContractState::Deleted(_)) { | ||
| Self::remove_contract(contract.contract_id); | ||
| return Ok(().into()); | ||
| } |
There was a problem hiding this comment.
In the bill_contract() context, the only way to have a contract in Deleted state is just after the handle_grace()
So i guess this block can be moved above
With this you can get rid of the if at line 1157
There was a problem hiding this comment.
Well, the contract is also moved to state Deleted if the user cancels it:
There was a problem hiding this comment.
Btw, I don't understand why there is a Deleted state for contract because I don't see something specific done with this info
Just removing the contract would not be fine?
or I miss something
There was a problem hiding this comment.
Well, the contract is also moved to state
Deletedif the user cancels it:
Ok, I see
So even when Deleted it is billed and need to reach the end of bill_contract()
There was a problem hiding this comment.
Btw, I don't understand why there is a
Deletedstate for contract because I don't see something specific done with this info Just removing the contract would not be fine? or I miss something
It's a leftover state from where we did not remove contracts from chain but marked them as deleted for ever. We can in a next iteration remove this maybe?
No description provided.