Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow twin to bond with a stash account #640

Merged
merged 8 commits into from
Mar 13, 2023
Merged

feat: allow twin to bond with a stash account #640

merged 8 commits into from
Mar 13, 2023

Conversation

renauter
Copy link
Collaborator

@renauter renauter marked this pull request as ready for review March 10, 2023 21:57
DylanVerstraete
DylanVerstraete approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@DylanVerstraete DylanVerstraete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Already approving, one comment though

substrate-node/pallets/pallet-tfgrid/src/lib.rs Outdated Show resolved Hide resolved
@DylanVerstraete
Copy link
Contributor

Also, rerun CI please

brandonpille
brandonpille approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. One small comment, already approving.

substrate-node/pallets/pallet-tfgrid/src/lib.rs Show resolved Hide resolved
@DylanVerstraete DylanVerstraete merged commit c5ddc2a into development Mar 13, 2023
@DylanVerstraete DylanVerstraete deleted the development_twin_bond_stash branch March 13, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@brandonpille brandonpille brandonpille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renauter @DylanVerstraete @brandonpille