Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tx hash to mintCompleted event #885

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Add tx hash to mintCompleted event #885

merged 3 commits into from
Nov 28, 2023

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented Nov 5, 2023 •
edited
Loading

Description

This PR add the tx hash to the MintCompleted event for better observbility and event correlation in the bridge.

Related Issues:

Checklist:

@sameh-farouk sameh-farouk marked this pull request as ready for review November 6, 2023 10:44
This was referenced Nov 7, 2023
Closed
Merged
muhamadazmy
muhamadazmy approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question! would this require migration since it changes the event type ? Also have the go/tc client also updated to handle this modified type ?

muhamadazmy
muhamadazmy requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to do the same changes in all clients

renauter
renauter approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@renauter renauter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Never seen migration for event type changes, this is only for storage items afaik
  • Go client was updated
  • Other clients seem outdated (I never worked on it) not sure they are really used (?)

@renauter renauter merged commit f9d31aa into development Nov 28, 2023
2 checks passed
@renauter renauter deleted the development-feat-update-pallet-tft-bridge-events branch November 28, 2023 12:51
@sameh-farouk sameh-farouk mentioned this pull request Dec 4, 2023
Closed
@sameh-farouk sameh-farouk mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@renauter renauter renauter approved these changes

@LeeSmet LeeSmet Awaiting requested review from LeeSmet LeeSmet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the stellar deposit tx hash in mintComlete event
3 participants
@sameh-farouk @muhamadazmy @renauter