Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add change power target to go client #901

Merged
merged 2 commits into from
Nov 29, 2023
Merged

add change power target to go client #901

merged 2 commits into from
Nov 29, 2023

Conversation

rawdaGastan
Copy link
Contributor

muhamadazmy
muhamadazmy requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the name, it looks good. Make sure you try it out on one node before merging

clients/tfchain-client-go/node.go Outdated
@@ -688,6 +688,32 @@ func (s *Substrate) SetNodePowerState(identity Identity, up bool) (hash types.Ha
return callResponse.Hash, nil
}

// ChangePowerTarget updates the power target
func (s *Substrate) ChangePowerTarget(identity Identity, nodeID uint32, up bool) (hash types.Hash, err error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why call it Change when every other method in this client uses Set

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the chain is using the change name but it's wrong. The Client doesn't have to use the same conviention

@muhamadazmy muhamadazmy merged commit 56ffc1f into development Nov 29, 2023
3 checks passed
@muhamadazmy muhamadazmy deleted the development_change_node_power_target branch November 29, 2023 12:10
sameh-farouk pushed a commit that referenced this pull request Jan 2, 2024
@rawdaGastan @sameh-farouk
add change power target to go client (#901)
5d6a2dd 
* add change power target to go client

* rename function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@renauter renauter Awaiting requested review from renauter renauter is a code owner

@LeeSmet LeeSmet Awaiting requested review from LeeSmet LeeSmet is a code owner

@sameh-farouk sameh-farouk Awaiting requested review from sameh-farouk sameh-farouk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rawdaGastan @muhamadazmy