Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uppdating tfchain values file #935

Merged
merged 1 commit into from
Jan 16, 2024
Merged

uppdating tfchain values file #935

merged 1 commit into from
Jan 16, 2024

Conversation

PeterNashaat
Copy link
Member

Description

When you use Helm's -f flag to specify a custom values file, Helm combines these values with the defaults in the chart's values.yaml. The custom values will override any matching default values in the chart.
Like: values.yaml#L52 , generates error error: invalid value '1.048576e+06' for '--rpc-max-connections <COUNT>': invalid digit found in string which should be > rpc_max_connections: "1048576"

this is not fix for https://github.com/threefoldtech/tf_operations/issues/2195, but update needed for validators installation

Copy link
Collaborator

@renauter renauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A doubt here after talking with @sameh-farouk
Why the need of such values specific to validator node if these values should be custom depending of kind of node ?

@PeterNashaat
Copy link
Member Author

  • Exactly such values is not needed as they are passed by default in the helm even if we use -f, that's why i commented some of them.

Copy link
Collaborator

@renauter renauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so if it is intentional and not set for a specific case we can go for it

@renauter renauter merged commit 68c63d8 into development Jan 16, 2024
2 checks passed
@renauter renauter deleted the tfnode_values_fix branch January 16, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants