Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile version-bump #973

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented May 31, 2024

Description

This PR add Makefile with a version-bump function that automate the version incrementing within the repo files.

# usage: > type=patch|minor|major make version-bump

it will also create the branch, the commit, and increment the spec_version and all other files mentioned in the release doc

Related Issues:

#975

@renauter
Copy link
Collaborator

renauter commented May 31, 2024

Great initiative!
Would be good to update the documentation here https://github.com/threefoldtech/tfchain/blob/development/docs/production/releases.md and also add a link to the versioning rules convention we are using (I don t remember where it is...).

I guess here https://github.com/threefoldtech/home/blob/master/wiki/contribution/release_process.md

@sameh-farouk
Copy link
Member Author

sameh-farouk commented Jun 4, 2024

Great initiative! Would be good to update the documentation here https://github.com/threefoldtech/tfchain/blob/development/docs/production/releases.md and also add a link to the versioning rules convention we are using (I don t remember where it is...).

I guess here https://github.com/threefoldtech/home/blob/master/wiki/contribution/release_process.md

Release doc updated! let me know if it is clear enough.
For the other doc and the versioning rules convention update lets do it on another PR later

Copy link
Collaborator

@renauter renauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear enough!
I suggest some documentation adjustments and we are all good

Ah and the codacy check is complaining
Probably md file is not formatted as expected

@renauter
Copy link
Collaborator

renauter commented Jun 5, 2024

I changed the codacy parameters here
https://app.codacy.com/p/542167/patterns/list?engine=547ff16b-d57c-4d75-8067-5ccf3ea88a00
to allow more than 80 characters lines (I set it to 200) for code pattern MD013 - Line length of markdownlint 0.33.0 tool.
And now it is all green from codacy side.

@renauter renauter merged commit 02dff00 into development Jun 5, 2024
2 checks passed
@renauter renauter deleted the development-make-version-bump branch June 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants