Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support network and machine light #1223

Merged
merged 3 commits into from
Oct 21, 2024
Merged

support network and machine light #1223

merged 3 commits into from
Oct 21, 2024

Conversation

rawdaGastan
Copy link
Collaborator

@rawdaGastan rawdaGastan commented Oct 10, 2024 •
edited
Loading

@rawdaGastan rawdaGastan force-pushed the development_deployment_v4 branch 4 times, most recently from 5db181c to e9b9af2 Compare October 15, 2024 09:25
@rawdaGastan rawdaGastan marked this pull request as ready for review October 15, 2024 09:26
@threefoldtech threefoldtech deleted a comment from ashraffouda Oct 15, 2024
xmonader
xmonader requested changes Oct 16, 2024
View reviewed changes
grid-client/zos/deployment.go Show resolved Hide resolved
grid-client/workloads/vm_light.go Outdated Show resolved Hide resolved
@rawdaGastan rawdaGastan force-pushed the development_deployment_v4 branch 2 times, most recently from 8d4ccec to b8bcc85 Compare October 16, 2024 12:01
Eslam-Nawara
Eslam-Nawara reviewed Oct 17, 2024
View reviewed changes
grid-client/zos/machine_light.go
// MachineNetworkLight structure
type MachineNetworkLight struct {
// Mycelium IP config, if planetary is true, but Mycelium is not set we fall back
// to yggdrasil support. Otherwise (if mycelium is set) a mycelium ip is used instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ygg here no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ygg or public ips

@rawdaGastan rawdaGastan merged commit 23def48 into development Oct 21, 2024
39 checks passed
@rawdaGastan rawdaGastan deleted the development_deployment_v4 branch October 21, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eslam-Nawara Eslam-Nawara Eslam-Nawara approved these changes

@ashraffouda ashraffouda ashraffouda approved these changes

@xmonader xmonader xmonader approved these changes

@MarioBassem MarioBassem Awaiting requested review from MarioBassem MarioBassem is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz Omarabdul3ziz is a code owner

@AbdelrahmanElawady AbdelrahmanElawady Awaiting requested review from AbdelrahmanElawady AbdelrahmanElawady is a code owner

@sameh-farouk sameh-farouk Awaiting requested review from sameh-farouk sameh-farouk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rawdaGastan @xmonader @ashraffouda @Eslam-Nawara