Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build for http server too #184

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add build for http server too #184

merged 1 commit into from
Apr 26, 2023

Conversation

brandonpille
Copy link
Contributor

This completes #183:

  • Another docker image is published containing the package grid_http_server

@brandonpille brandonpille linked an issue Apr 25, 2023 that may be closed by this pull request
Release http server in docker image of tfgrid client #183
Closed
AhmedHanafy725
AhmedHanafy725 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AhmedHanafy725 AhmedHanafy725 merged commit f7321ae into development Apr 26, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the 183-release-http-server-in-docker-image-of-tfgrid-client branch April 26, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release http server in docker image of tfgrid client
2 participants
@brandonpille @AhmedHanafy725