Add search in solutions #2190
Merged
Add search in solutions #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
requested review from
AhmedHanafy725,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R and
mohamedamer453
as code owners
Screencast.from.02-18-2024.02.16.02.PM.webm |
I don't think we can use combox because it's default searching will be remove after any So I'd recommend using |
AlaaElattar
approved these changes
Feb 21, 2024
Comment on lines
3
to
9
| <v-text-field | ||
| label="Search Applications" | ||
| v-model="searchItem" | ||
| class="mb-5" | ||
| @input="filterCards" | ||
| clearable | ||
| ></v-text-field> |
There was a problem hiding this comment.
why do we need @input ? we already using vue so we can easily check if value is updated
There was a problem hiding this comment.
Replaced function logic w computed variable.
|
Also if a user wrote a search query which doesn't match any application we should show a message with some text message (e.g |
MohamedElmdary
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Related Issues
Checklist