Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload component when user clicks on back from any solution #2191

Merged
merged 1 commit into from
Feb 18, 2024
Merged

reload component when user clicks on back from any solution #2191

merged 1 commit into from
Feb 18, 2024

Conversation

AlaaElattar
Copy link
Contributor

Description

  • After deployment is done, the solution inputs should be reset when the back button is pressed.

Changes

  • Dispatch new event in weblet layout to be catched in view layout and refresh the compoent.
  • Instead of modifying each single solution

Related Issues

Screencast.from.02-18-2024.12.58.44.PM.webm

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R
0oM4R approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@AhmedHanafy725 AhmedHanafy725 changed the base branch from development to development_314 February 18, 2024 13:46
@amiraabouhadid amiraabouhadid merged commit 1818b97 into development_314 Feb 18, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_reload_component branch February 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@0oM4R 0oM4R 0oM4R approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlaaElattar @amiraabouhadid @0oM4R