Check farm has enough public ips before creating the extrinsics #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaaElattar
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
0oM4R and
mohamedamer453
as code owners
AhmedHanafy725
approved these changes
Feb 21, 2024
MohamedElmdary
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alongside checking the node resources before proceeding with creating the extrinsic, we should check if the deployments require public IPs and validate that against the farm.
Changes
checking if farm has enough public ip for each vm , while creating deployment.
This won't make huge difference from playground as if there're no public ips, no nodes will appear, but from scripts it will be checked before creating deployment.
Related Issues
#1822
Checklist