Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reserve/unreserve buttons in the actions of the nodes table #2223

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Add reserve/unreserve buttons in the actions of the nodes table #2223

merged 6 commits into from
Feb 27, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Feb 21, 2024 •
edited
Loading

Description

Add Reserve, Reserved, and Unreserve buttons at the node table

Changes

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@AhmedHanafy725
Copy link
Contributor

@ehab-hassan can you please check the buttons' colors?

@AhmedHanafy725 AhmedHanafy725 changed the title Add reserve buttons Add reserve/unreserve buttons in the actions of the nodes table Feb 21, 2024
@ehab-hassan
Copy link
Contributor

@ehab-hassan can you please check the buttons' colors?

For Reserve Is Ok
but while there is no action at the Reserved we can make it just red text(error color) without a background or tonal background like down
image

can u show me first without background just red text like this
image

@samaradel samaradel marked this pull request as draft February 22, 2024 07:24
@samaradel
Copy link
Contributor Author

@AhmedHanafy725 @ehab-hassan updated

@samaradel samaradel marked this pull request as ready for review February 22, 2024 08:58
@ehab-hassan
Copy link
Contributor

ehab-hassan commented Feb 22, 2024 •
edited
Loading

@AhmedHanafy725 @ehab-hassan updated

Nice last thing can you remove hover from Reserved so the user make sure there is no action happening there

ehab-hassan
ehab-hassan approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@ehab-hassan ehab-hassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at colors

@AlaaElattar
Copy link
Contributor

  • You shouldn't allow user to reserve node while logging out, also no error appeared !
Screencast.from.02-22-2024.12.11.28.PM.webm

@samaradel samaradel marked this pull request as draft February 22, 2024 10:49
@samaradel samaradel marked this pull request as ready for review February 25, 2024 12:27
@amiraabouhadid amiraabouhadid merged commit bc6f5cf into development_314 Feb 27, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_314_node_finder branch February 27, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedElmdary MohamedElmdary MohamedElmdary left review comments

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@ehab-hassan ehab-hassan ehab-hassan approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@maayarosama maayarosama Awaiting requested review from maayarosama

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@0oM4R 0oM4R Awaiting requested review from 0oM4R

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@samaradel @AhmedHanafy725 @ehab-hassan @AlaaElattar @MohamedElmdary @amiraabouhadid