Include FarmId in contracts table #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaaElattar
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
0oM4R and
mohamedamer453
as code owners
maayarosama
approved these changes
Feb 28, 2024
AhmedHanafy725
requested changes
Feb 29, 2024
Comment on lines
60
to
65
| let farmId: number; | ||
| try { | ||
| farmId = (await grid.nodes.get({ id: c.nodeID })).farmId; | ||
| } catch { | ||
| farmId = 0; | ||
| } |
There was a problem hiding this comment.
we already doing a call to get the node status, I believe we can get the farm id with the same call.
maayarosama
approved these changes
Mar 5, 2024
MohamedElmdary
approved these changes
Mar 5, 2024
AhmedHanafy725
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Related Issues
Checklist