Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a cardsLength value and changing the condition #2396

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

maayarosama
Copy link
Contributor

@maayarosama maayarosama commented Mar 12, 2024

Description

Removing error message when gpu details is retrieved
Peek 2024-03-12 11-50

Changes

Adding a cardsLength variable because node.cards.length doesn't reflect when changed

Related Issues

#2298

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good jo ya Mayar :)

@amiraabouhadid amiraabouhadid merged commit 13f93ab into development_314 Mar 12, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_314_gpu_card branch March 12, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants