Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the statistics endpoint to get nodes used resources. #248

Merged
merged 5 commits into from
May 24, 2023
Merged

Use the statistics endpoint to get nodes used resources. #248

merged 5 commits into from
May 24, 2023

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented May 23, 2023

Description

The statistics endpoint provides more accurate data about the used resources of the node.

Changes

  • Add the INodeResources interface
  • Modify the INodeStatistics interface
  • use Axios to fetch statistics with timeout 3ms
  • Handle fetching statistics errors if the node is up

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@0oM4R 0oM4R mentioned this pull request May 23, 2023
Closed
@0oM4R 0oM4R requested a review from AhmedHanafy725 May 24, 2023 11:33
@AhmedHanafy725 AhmedHanafy725 merged commit 56b8bfe into development May 24, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_dashboard_useStatistics branch May 24, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0oM4R @AhmedHanafy725