Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding static website application #2481

Merged
merged 20 commits into from
May 16, 2024
Merged

Adding static website application #2481

merged 20 commits into from
May 16, 2024

Conversation

maayarosama
Copy link
Contributor

@maayarosama maayarosama commented Mar 20, 2024 •
edited
Loading

Description

Adding a Caddy Application

Changes

List of changes this PR includes

Related Issues

#2088

Documentation PR

threefoldtech/info_grid#463

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@maayarosama maayarosama changed the title Adding caddy application Adding static website application Mar 24, 2024
@maayarosama maayarosama marked this pull request as ready for review March 24, 2024 08:16
@zaelgohary
Copy link
Contributor

The solution type should be renamed.

image

@maayarosama
Copy link
Contributor Author

The solution type should be renamed.

image

Any suggestions?

@zaelgohary
Copy link
Contributor

The solution type should be renamed.
image

Any suggestions?

Same name different format. Like Full VM.

@maayarosama maayarosama marked this pull request as draft March 24, 2024 12:49
@maayarosama maayarosama marked this pull request as ready for review March 31, 2024 04:18
zaelgohary
zaelgohary previously approved these changes Mar 31, 2024
View reviewed changes
packages/playground/src/views/solutions_view.vue Outdated Show resolved Hide resolved
packages/playground/src/weblets/tf_deployment_list.vue Show resolved Hide resolved
@zaelgohary zaelgohary dismissed their stale review March 31, 2024 10:51

Approved by mistake

@zaelgohary
Copy link
Contributor

Solution name should be separated by a space.

image

@maayarosama maayarosama marked this pull request as ready for review May 7, 2024 10:56
zaelgohary
zaelgohary approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

amiraabouhadid
amiraabouhadid requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add more validation rules such as follows the https://github.com/<github-account>/<repo-name>.git or the git@github.com:<github-account>/<repo-name>.git format.
Because it currently accepts invalid entries like this:
Screenshot from 2024-05-07 16-19-23
It might be a good idea to pre-fetch the repo when validating

amiraabouhadid

This comment was marked as outdated.

Sign in to view

@amiraabouhadid amiraabouhadid self-requested a review May 8, 2024 09:14
amiraabouhadid
amiraabouhadid requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run a fetch on the entered repo to validate that repo exists. You can use github API https://docs.github.com/en/rest/repos?apiVersion=2022-11-28#get

@xmonader
Copy link
Contributor

xmonader commented May 8, 2024

please run a fetch on the entered repo to validate that repo exists

Only in case of github and also @amiraabouhadid link the endpoint to check if the repo exists or not please

@maayarosama maayarosama requested a review from xmonader May 13, 2024 09:44
@maayarosama maayarosama requested a review from xmonader May 14, 2024 08:28
@amiraabouhadid
Copy link
Contributor

how does it still accept github urls like this though
image

@amiraabouhadid amiraabouhadid merged commit f847908 into development May 16, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_caddy branch May 16, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maayarosama @zaelgohary @amiraabouhadid @xmonader