Fix: node uptime #2497
Merged
Fix: node uptime #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add getting minting reports to try block to make sure the function will continue even if there is an error with fetching receipts
0oM4R
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
mohamedamer453 and
samaradel
as code owners
| @@ -204,7 +204,7 @@ export default { | |||
| async function getUserNodes() { | |||
| try { | |||
| loading.value = true; | |||
| const twinId = profileManager.profile!.twinId; | |||
| const twinId = 11261; | |||
There was a problem hiding this comment.
why did we use 11261 as twinId instead of logged in user's one?
MohamedElmdary
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for the mentioned nodes, they were created early this month, so there will be no minting receipts for them until the next month,
so getting the reports was failing and exiting the function, The next few lines in the function is related to up-time calculation, which was not reached, so the result is 0%
Changes
add getting minting reports to try block to make sure the function will continue even if there is an error with fetching receipts
Related Issues
Documentation PR
For UI changes, Plaese provide the Documetation PR on info_grid
Checklist