Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reserve button issues in Node finder #2526

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix reserve button issues in Node finder #2526

merged 2 commits into from
Apr 3, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Apr 2, 2024 •
edited
Loading

Changes

  • Made profile value in reserve button is computed
  • Fix reloadTable emits typos
  • Used Vue reactivity to update the node card upon reserving/unreserving a node by setting the key to the node card component to node.rentedByTwinId
  • Removed outlined from the reserve/unreserve button as it was faded inside the card

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as draft April 2, 2024 23:49
@zaelgohary zaelgohary marked this pull request as ready for review April 3, 2024 02:28
AlaaElattar
AlaaElattar approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@zaelgohary zaelgohary merged commit 561dfe6 into development Apr 3, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_fix_reserve branch April 3, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @MohamedElmdary @AlaaElattar