Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit subdomain char limit #2573

Merged
merged 8 commits into from
May 8, 2024
Merged

Edit subdomain char limit #2573

merged 8 commits into from
May 8, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Apr 16, 2024 •
edited
Loading

Changes

  • Validate subdomain
  • Edit subdomain to include prefix by default
  • Edit max char subdomain as the validation function used gets a name argument with max 30 char
  • Edit max contract name in get_name_contract to 30
  • Edit tooltip & table name

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary
Copy link
Member

MohamedElmdary commented Apr 17, 2024 •
edited
Loading

Shouldn't we keep deployment as before with oldPrefix?

@zaelgohary zaelgohary marked this pull request as draft April 18, 2024 08:31
@zaelgohary zaelgohary marked this pull request as ready for review April 30, 2024 10:48
@zaelgohary zaelgohary mentioned this pull request Apr 30, 2024
Closed
AhmedHanafy725
AhmedHanafy725 previously requested changes Apr 30, 2024
View reviewed changes
packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved
packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved
packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved
packages/playground/src/components/manage_gateway_dialog.vue Outdated Show resolved Hide resolved
@MohamedElmdary MohamedElmdary dismissed AhmedHanafy725’s stale review May 8, 2024 14:10

changed applied but reviewer is off for rest of the week

@MohamedElmdary MohamedElmdary merged commit 426b406 into development May 8, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_normalize_subdomain branch May 8, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@samaradel samaradel samaradel approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @MohamedElmdary @samaradel @AhmedHanafy725 @Mahmoud-Emad