Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume workload #2645

Merged
merged 2 commits into from
May 7, 2024
Merged

Add volume workload #2645

merged 2 commits into from
May 7, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented May 2, 2024 •
edited
Loading

Description

  • Added volume workload in grid client and used it while creating disk instead of zmount.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

amiraabouhadid
amiraabouhadid approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

Base automatically changed from development_2.5 to development May 7, 2024 12:16
An error occurred while trying to automatically change base from development_2.5 to development May 7, 2024 12:16
@zaelgohary zaelgohary merged commit 19d71cc into development May 7, 2024
@zaelgohary zaelgohary deleted the development_2.5_add_volume branch May 7, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @AlaaElattar @amiraabouhadid