Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix listing multiple vms in same deployment #2656

Merged
merged 1 commit into from
May 8, 2024

Conversation

AlaaElattar
Copy link
Contributor

Description

When deploying 2 VMs on a single deployment, the dashboard can list only one of the VMs.

Changes

  • Handled case of leader and workers only for caprover.
  • Rest of Soultions will be listed as leaders.

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@amiraabouhadid amiraabouhadid merged commit 43d8949 into development May 8, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_fix_listing branch May 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants