Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SMTP only with public ipv4 #2681

Merged
merged 5 commits into from
May 14, 2024
Merged

Enable SMTP only with public ipv4 #2681

merged 5 commits into from
May 14, 2024

Conversation

AlaaElattar
Copy link
Contributor

Description

The SMTP ports are blocked on the private network. so to have it working, the solution should have a public IP.

Changes

  • alert added telling user that smtp server need ipv4.
  • If user enabled smtp without ipv4, ipv4 will be enabled automatically.
  • If user diasbled ipv4 with smtp enabled, smtp will be disabled automatically.

Related Issues

Documentation PR

Screencast.from.05-12-2024.03.18.03.PM.webm

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

zaelgohary
zaelgohary reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be implemented in Owncloud also.

tfgrid-sdk-ts/packages/playground/src/weblets/tf_owncloud.vue

Lines 109 to 113 in b600e08

<template #smtp>
<SmtpServer v-model="smtp" tls ssl email>
Configure these settings only If you have an smtp service and you know what you’re doing.
</SmtpServer>
</template>

@AlaaElattar AlaaElattar marked this pull request as draft May 13, 2024 07:31
zaelgohary
zaelgohary reviewed May 13, 2024
View reviewed changes
packages/playground/src/components/smtp_server.vue Outdated
Comment on lines 8 to 10
<v-alert variant="tonal" type="warning" class="mt-3">
SMTP server requires IPv4. Please ensure that your network configuration supports IPv4.
</v-alert>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we ensure that IPV4 is enabled if the SMTP is chosen, can we change the phrasing of the alert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What do u think about this ?

image

@AlaaElattar AlaaElattar marked this pull request as ready for review May 13, 2024 07:33
@AlaaElattar
Copy link
Contributor Author

Should be implemented in Owncloud also.

tfgrid-sdk-ts/packages/playground/src/weblets/tf_owncloud.vue

Lines 109 to 113 in b600e08

<template #smtp>
<SmtpServer v-model="smtp" tls ssl email>
Configure these settings only If you have an smtp service and you know what you’re doing.
</SmtpServer>
</template>

  • is it hidden ??
    image

Mahmoud-Emad
Mahmoud-Emad requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Amira

packages/playground/src/weblets/tf_mattermost.vue Outdated Show resolved Hide resolved
packages/playground/src/weblets/tf_taiga.vue Outdated Show resolved Hide resolved
Mahmoud-Emad
Mahmoud-Emad approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Alaa

amiraabouhadid
amiraabouhadid previously approved these changes May 13, 2024
View reviewed changes
zaelgohary
zaelgohary reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMTP toggle now has some issues. It doesn't get enabled on first click. It gets enabled on the third. Also, switching the SMTP toggle to off would not switch off the IPV4 toggle.

SMTP.webm

@amiraabouhadid amiraabouhadid dismissed their stale review May 13, 2024 13:36

Might be an error

@AlaaElattar AlaaElattar marked this pull request as draft May 14, 2024 06:44
@AlaaElattar
Copy link
Contributor Author

SMTP toggle now has some issues. It doesn't get enabled on first click. It gets enabled on the third. Also, switching the SMTP toggle to off would not switch off the IPV4 toggle.

SMTP.webm

  • Switching smtp off, shouldn't swtich public ipv4.
  • smtp requires ipv4, but enabling ipv4 not necessary enable smtp unless user wants it.

@AlaaElattar
Copy link
Contributor Author

SMTP toggle now has some issues. It doesn't get enabled on first click. It gets enabled on the third. Also, switching the SMTP toggle to off would not switch off the IPV4 toggle.

SMTP.webm

  • for the button, i can open separate issue.

@AlaaElattar AlaaElattar marked this pull request as ready for review May 14, 2024 07:38
@AlaaElattar AlaaElattar marked this pull request as draft May 14, 2024 08:32
@AlaaElattar AlaaElattar marked this pull request as ready for review May 14, 2024 10:54
zaelgohary
zaelgohary approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Alaa! ❤️

@AlaaElattar AlaaElattar merged commit 1c67d82 into development May 14, 2024
3 checks passed
@AlaaElattar AlaaElattar deleted the development_enable_ipvs_smtp branch May 14, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid left review comments

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlaaElattar @zaelgohary @amiraabouhadid @Mahmoud-Emad