Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipv6 to filters in Node Finder #2738

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Add ipv6 to filters in Node Finder #2738

merged 11 commits into from
Jun 9, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented May 20, 2024 •
edited
Loading

Description

  • Add ipv6 to filters in node finder
  • Update Grid Client filter to include hasIPv6 and include the new filter in Playground
  • Update farm filters to include node_has_ipv6 in grid client, grid proxy & playground
ipv6.webm

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

AhmedHanafy725
AhmedHanafy725 requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a switch for ipv6 while deploying any solution, but this switch doesn't filter the nodes as it wasn't supported. please make sure it filter the nodes there too.

@zaelgohary zaelgohary marked this pull request as draft May 21, 2024 07:19
@zaelgohary zaelgohary marked this pull request as ready for review May 21, 2024 10:15
maayarosama
maayarosama requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@maayarosama maayarosama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPv6 filter doesn't work in micro vm
Peek 2024-05-21 16-08
2024-05-21_16-09

@zaelgohary zaelgohary marked this pull request as draft May 21, 2024 13:26
@zaelgohary zaelgohary marked this pull request as ready for review May 26, 2024 13:59
@zaelgohary
Copy link
Contributor Author

IPv6 filter doesn't work in micro VM

I was using a wrong filter query. It should've be ipv6 only as seen below. Should be fixed now.

image

AhmedHanafy725
AhmedHanafy725 requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened an issue for supporting this query on farms too to show only the farms that have ipv6 in case it was selected
threefoldtech/tfgrid-sdk-go#1040

packages/grid_client/src/primitives/nodes.ts Outdated Show resolved Hide resolved
@zaelgohary zaelgohary marked this pull request as draft May 28, 2024 08:56
@zaelgohary zaelgohary marked this pull request as ready for review June 9, 2024 09:39
@zaelgohary zaelgohary merged commit 44f15ae into development Jun 9, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_filter_by_ipv6 branch June 9, 2024 12:49
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama maayarosama approved these changes

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @MohamedElmdary @AhmedHanafy725 @maayarosama @xmonader