Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update farm name validation #2789

Merged
merged 5 commits into from
May 29, 2024
Merged

Update farm name validation #2789

merged 5 commits into from
May 29, 2024

Conversation

amiraabouhadid
Copy link
Contributor

Changes

Added validation for farm name to check if farm name exists in all farms on tfchain

Related Issues

#2764

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

maayarosama
maayarosama requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@maayarosama maayarosama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't list all Farms, you should filter by farm name from the grid proxy and it the Farm exists then you should display it as a field validation error and block the creating of the farm

@MohamedElmdary
Copy link
Member

shouldn't we remove the unused code?
https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/dashboard/components/create_farm.vue#L82-L85
https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/dashboard/farms_view.vue#L8-L9
https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/dashboard/farms_view.vue#L28-L33
https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/dashboard/components/user_farms.vue#L332-L344

@MohamedElmdary
Copy link
Member

@amiraabouhadid if component no longer getting userFarms as ref so should we remove it's code?

https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/dashboard/farms_view.vue#L8-L9

https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/dashboard/farms_view.vue#L28-L33

Mahmoud-Emad
Mahmoud-Emad approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Amira :)

@amiraabouhadid amiraabouhadid merged commit d12e4ee into development May 29, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_update_farm_name_validation branch May 29, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amiraabouhadid @MohamedElmdary @Mahmoud-Emad @maayarosama