Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter by up & standby nodes in Node Finder #2883

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Filter by up & standby nodes in Node Finder #2883

merged 4 commits into from
Jun 6, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jun 5, 2024 •
edited
Loading

Changes

  • Add up&standby filter in grid proxy client & playground
  • Updated the NodeStatus in assertIn

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as draft June 5, 2024 14:08
@zaelgohary zaelgohary marked this pull request as ready for review June 5, 2024 15:07
Mahmoud-Emad
Mahmoud-Emad reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Zainab

packages/gridproxy_client/src/builders/gateways.ts Show resolved Hide resolved
@zaelgohary zaelgohary merged commit 2747f34 into development Jun 6, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_filter_up_standby branch June 6, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @AlaaElattar @Mahmoud-Emad