Fix manage multiple vms deployment #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed gateways - feat: Add deploymentName option to allow deleting a single machine from deployment instead of the entire deployment
… to show only machine owned gateways
…t with multiple machines will have same deploymentName for all machines - feat: Use ip to filter deployment gateways while deleting a deployment - feat: Use deploymentName option to delete_machine instead of delete entire deployment
MohamedElmdary
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
Calling loadDeployment method outside the for loop
0oM4R
approved these changes
Jun 11, 2024
MohamedElmdary
deleted the
development_fix_manage_multiple_vms_deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix manage multiple vms deployment
Changes
Related Issues
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist