Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide the unlock button on node contracts that on rented nodes #2979

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jun 13, 2024

Description

after changes that have been made in #2872 we can't access the nodeid directly so the value is undefined, then the condition is always false, This makes the button appears

Changes

  • Fix: update accessing the nodeId as it becomes of type NormalizedContracts
  • Make the nodeIds as Set to avoid node ids redundancy

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

…tracts`

this is necessary now after changes in #2872
Make the nodeIds as Set to avoid node ids redundancy
restore unlock contracts logic, the line was deleted by mistake
@0oM4R 0oM4R merged commit b50f001 into development Jun 13, 2024
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_fix_isNodeInRentContracts branch July 2, 2024 07:14
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants