Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make title card at all pages to be consistent #2999

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Make title card at all pages to be consistent #2999

merged 5 commits into from
Jun 24, 2024

Conversation

ehab-hassan
Copy link
Contributor

@ehab-hassan ehab-hassan commented Jun 20, 2024 •
edited
Loading

Description

add header at all pages to be consistent

Changes

all these pages need a title card
Miniting
Node Finder
VM #2908
orchestrators #2908
Application
Contracts
SSH Key
Farm Finder

Related Issues

#2908
#2224

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

image
image
image
image
image
image
image
image

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@ehab-hassan ehab-hassan marked this pull request as draft June 20, 2024 14:18
@ehab-hassan ehab-hassan marked this pull request as ready for review June 23, 2024 12:42
Mahmoud-Emad
Mahmoud-Emad reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya MR Ehab!

packages/playground/src/views/nodes.vue Outdated Show resolved Hide resolved
packages/playground/src/views/sshkey_view.vue Outdated Show resolved Hide resolved
Mahmoud-Emad
Mahmoud-Emad approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead!

@ehab-hassan ehab-hassan merged commit 333c66a into development Jun 24, 2024
3 checks passed
@ehab-hassan ehab-hassan deleted the development_alltitle_consistent branch June 24, 2024 08:12
@ehab-hassan ehab-hassan restored the development_alltitle_consistent branch June 24, 2024 10:14
@ehab-hassan ehab-hassan deleted the development_alltitle_consistent branch June 24, 2024 10:53
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ehab-hassan @samaradel @Mahmoud-Emad @xmonader