Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node Pilot domain #3010

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Add Node Pilot domain #3010

merged 8 commits into from
Jun 27, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jun 23, 2024 •
edited
Loading

Description

  • Add Node Pilot domain

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Mahmoud-Emad
Mahmoud-Emad requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Zainab!

packages/playground/src/weblets/tf_node_pilot.vue Outdated Show resolved Hide resolved
packages/playground/src/weblets/tf_node_pilot.vue Outdated Show resolved Hide resolved
packages/playground/src/weblets/tf_node_pilot.vue Outdated Show resolved Hide resolved
@zaelgohary zaelgohary marked this pull request as draft June 25, 2024 08:52
@zaelgohary zaelgohary marked this pull request as ready for review June 25, 2024 09:52
0oM4R
0oM4R approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a domain name works fine, some other flows have bugs will open issues for them

image

Screencast.from.27.2024.EEST.01.19.10.webm

@zaelgohary zaelgohary merged commit 68fe8b8 into development_2.6 Jun 27, 2024
4 checks passed
@zaelgohary zaelgohary deleted the development_2.6_node_pilot_domain branch June 27, 2024 10:30
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zaelgohary @Mahmoud-Emad @0oM4R @xmonader