Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix email wait #3295

Merged
merged 11 commits into from
Aug 18, 2024
Merged

fix email wait #3295

merged 11 commits into from
Aug 18, 2024

Conversation

A-Harby
Copy link
Contributor

@A-Harby A-Harby commented Aug 12, 2024 •
edited
Loading

Description

  • The email is now auto-written for the mnemonic that was already logged in before.
  • Commented Get TFT button test since it was removed.
  • Fix import (for some reason it was removed).

Changes

Only add a wait for the email input to be intractable.

Related Issues

#3147
#2529

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@A-Harby
Copy link
Contributor Author

A-Harby commented Aug 13, 2024

https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/10372486195/job/28715320204

@A-Harby A-Harby marked this pull request as ready for review August 13, 2024 15:52
Mahmoud-Emad
Mahmoud-Emad approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Harby

@A-Harby A-Harby merged commit e53d74e into development Aug 18, 2024
12 checks passed
@A-Harby A-Harby deleted the development_fix_email_wait_selenium branch August 18, 2024 07:25
@A-Harby A-Harby mentioned this pull request Aug 18, 2024
Closed
1 task
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@A-Harby @Mahmoud-Emad @0oM4R @xmonader