Allow using `username` and `email` in SMTP configuration #3398

samaradel · 2024-09-10T14:15:25Z

Description

Remove isDiscourse check and apply adding email or username for all apps with SMTP.
Add the minimum and maximum lengths for the username and email.
validate the email input to accept the username too.
Accept usernames containing dashes and underscores they must start with an alphanumeric character and validate them.

limit the password length to 69 chars as per sendgrid documentation

Changes

Related Issues

🐞 [Bug]: Change mail config validator on taiga #3343

Tested Scenarios

Check if the user used an email or username in the Email/username input and validate it.
Check if the input accepts less than 2 characters.
Check if the input accepts more than 50 characters.
Check if the username or email can start with anything except an alphanumeric character.
Check if we could leave the input empty

Documentation PR

Update SMTP Server docs info_grid#645

Checklist

…pps with smtp

packages/playground/src/components/smtp_server.vue

Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>

packages/playground/src/components/smtp_server.vue

packages/playground/src/weblets/tf_discourse.vue

packages/playground/src/utils/validators.ts

Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>

packages/playground/src/utils/validators.ts

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

packages/playground/src/components/smtp_server.vue

packages/playground/src/utils/validators.ts

0oM4R · 2024-09-22T06:57:18Z

please mention the idea behind the validation rules, 69 characters, and the regex of the username

packages/playground/src/utils/validators.ts

Co-authored-by: Omar Kassem <omarksm09@gmail.com>

xmonader · 2024-09-29T15:54:05Z

packages/playground/tests/utils/isValidSmtp.test.ts

+  });
+
+  it("returns an error message for white spaces in username", () => {
+    const input = "invalid username";


there're more types of spaces beyond " " there's is \t and \v

noted in the current validation.

- Accept usernames that contain dashs and underscores and it must start with an alphabetical character and validate them

0oM4R · 2024-10-08T08:10:20Z

packages/playground/src/components/smtp_server.vue

-            return isDiscourse ? undefined : validators.isEmail('Please provide a valid email address.')(v);
+          validators.required('Email or Username is required.'),
+          validators.minLength('Username must be at least 2 characters.', 2),
+          validators.maxLength('Username must be at least 50 characters.', 50),


we shouldn't use the at least on max length

also is this validation on user name only? what if the email exceeds the 50 char ? the length validation message will appear

0oM4R

the validation need a revisit

0oM4R

Check if the username or email can start with anything except an alphabetical character.

email pass the validation starting with number, also please add this test case to unit test

0oM4R · 2024-10-17T13:15:30Z

this field should got validated on submit i think

Screencast.from.2024-10-17.16-10-24.webm

samaradel · 2024-10-20T07:45:54Z

@0oM4R ok, open an issue for this please

Remove isDiscourse check and apply adding email or username for all a…

cd7e4e4

…pps with smtp

samaradel requested review from AhmedHanafy725, zaelgohary, maayarosama, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar, 0oM4R and mohamedamer453 as code owners September 10, 2024 14:15

samaradel changed the title ~~Remove isDiscourse check and apply adding email or username for all a…~~ Allow username or email in SMTP configuration Sep 10, 2024

samaradel changed the title ~~Allow username or email in SMTP configuration~~ Allow using username and email in SMTP configuration Sep 10, 2024

zaelgohary reviewed Sep 11, 2024

View reviewed changes

packages/playground/src/components/smtp_server.vue Outdated Show resolved Hide resolved

Update packages/playground/src/components/smtp_server.vue

6f50303

Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>

zaelgohary reviewed Sep 11, 2024

View reviewed changes

packages/playground/src/components/smtp_server.vue Outdated Show resolved Hide resolved

packages/playground/src/weblets/tf_discourse.vue Outdated Show resolved Hide resolved

packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved

Update packages/playground/src/weblets/tf_discourse.vue

f994a54

Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>

samaradel marked this pull request as draft September 11, 2024 12:36

Validate SMTP username/email

b7a7836

samaradel marked this pull request as ready for review September 19, 2024 08:29

samaradel requested a review from zaelgohary September 19, 2024 08:30

Fix build

81af97c

github-advanced-security bot found potential problems Sep 19, 2024

View reviewed changes

packages/playground/src/utils/validators.ts Fixed Show fixed Hide fixed

Apply code scanning fix for overly permissive regular expression range

bc4c149

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

0oM4R reviewed Sep 22, 2024

View reviewed changes

packages/playground/src/components/smtp_server.vue Show resolved Hide resolved

0oM4R reviewed Sep 22, 2024

View reviewed changes

packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved

0oM4R reviewed Sep 22, 2024

View reviewed changes

packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved

maayarosama reviewed Sep 22, 2024

View reviewed changes

packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved

samaradel and others added 2 commits September 23, 2024 12:25

Update packages/playground/src/utils/validators.ts

4c1c955

Co-authored-by: Omar Kassem <omarksm09@gmail.com>

rn validate smtp function

f2e0fc8

xmonader reviewed Sep 29, 2024

View reviewed changes

samaradel marked this pull request as draft October 1, 2024 08:08

- Add min length and max length for the username and Email

788077b

- Accept usernames that contain dashs and underscores and it must start with an alphabetical character and validate them

samaradel requested a review from xmonader October 2, 2024 10:25

samaradel marked this pull request as ready for review October 2, 2024 10:25

samaradel marked this pull request as draft October 2, 2024 11:58

samaradel added 2 commits October 2, 2024 15:02

Add doc string for IsAlphaExpectDashAndUnderscore validator

0d6a1b3

Add unit test for IsAlphaExpectDashAndUnderscore function

9fb6875

samaradel marked this pull request as ready for review October 2, 2024 12:52

0oM4R reviewed Oct 8, 2024

View reviewed changes

0oM4R requested changes Oct 8, 2024

View reviewed changes

samaradel marked this pull request as draft October 9, 2024 07:56

samaradel added 2 commits October 9, 2024 13:35

Update SMTP input validation msg

4ad30a6

Update SMTP input validation msg

51465dc

samaradel marked this pull request as ready for review October 9, 2024 10:37

samaradel requested a review from 0oM4R October 9, 2024 10:37

0oM4R requested changes Oct 10, 2024

View reviewed changes

0oM4R mentioned this pull request Oct 10, 2024

🐞 [Bug]: solutions gives bad gateway #3449

Closed

1 task

Remove number validator of first char and add test case for it

b9ff25e

samaradel requested a review from 0oM4R October 13, 2024 11:09

samaradel marked this pull request as draft October 15, 2024 10:06

samaradel marked this pull request as ready for review October 16, 2024 14:57

Modify the valitator function to accept numbers too

17e8dba

0oM4R approved these changes Oct 21, 2024

View reviewed changes

0oM4R mentioned this pull request Oct 21, 2024

smtp tab: validate on touch and on submit only #3540

Open

amiraabouhadid approved these changes Oct 21, 2024

View reviewed changes

samaradel merged commit e87174a into development Oct 21, 2024
10 checks passed

samaradel deleted the development_smtp_validator branch October 21, 2024 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow using `username` and `email` in SMTP configuration #3398

Allow using `username` and `email` in SMTP configuration #3398

samaradel commented Sep 10, 2024 •

edited

Loading

0oM4R commented Sep 22, 2024

xmonader Sep 29, 2024

samaradel Oct 2, 2024

0oM4R Oct 8, 2024 •

edited

Loading

0oM4R Oct 8, 2024

samaradel Oct 9, 2024

0oM4R left a comment

0oM4R left a comment

0oM4R commented Oct 17, 2024

samaradel commented Oct 20, 2024

Allow using username and email in SMTP configuration #3398

Allow using username and email in SMTP configuration #3398

Conversation

samaradel commented Sep 10, 2024 • edited Loading

Description

Changes

Related Issues

Tested Scenarios

Documentation PR

Checklist

0oM4R commented Sep 22, 2024

xmonader Sep 29, 2024

Choose a reason for hiding this comment

samaradel Oct 2, 2024

Choose a reason for hiding this comment

0oM4R Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

0oM4R Oct 8, 2024

Choose a reason for hiding this comment

samaradel Oct 9, 2024

Choose a reason for hiding this comment

0oM4R left a comment

Choose a reason for hiding this comment

0oM4R left a comment

Choose a reason for hiding this comment

0oM4R commented Oct 17, 2024

samaradel commented Oct 20, 2024

Allow using `username` and `email` in SMTP configuration #3398

Allow using `username` and `email` in SMTP configuration #3398

samaradel commented Sep 10, 2024 •

edited

Loading

0oM4R Oct 8, 2024 •

edited

Loading