Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit disk name in full vm #458

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Edit disk name in full vm #458

merged 2 commits into from
Jun 4, 2023

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jun 1, 2023 •
edited
Loading

Description

Remove additional disk path in Fullvm

Changes

  • Change the disk label in fullvm (if it's not the default) to "Disk", other than that, include disk path in the label

Fullvm Deployment

image

Kubernetes Deployment

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary merged commit b8d831d into development Jun 4, 2023
@zaelgohary zaelgohary deleted the development_disk_mount branch June 4, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @xmonader @Mahmoud-Emad