Move capacity url fn to a separate file #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
requested review from
AhmedHanafy725,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
xmonader
reviewed
Jun 4, 2023
| @@ -0,0 +1,14 @@ | |||
| import { NetworkEnv } from "@threefold/grid_client"; | |||
|
|
|||
| const network = process.env.NETWORK || (window as any).env.NETWORK; | |||
There was a problem hiding this comment.
this line isn't needed, it can be passed from the calling function, the file should be only the getCapacityURL function parameterized in the a network var, the usage of that function should be in the right context
xmonader
reviewed
Jun 4, 2023
| return `https://dashboard.${network}.grid.tf/explorer/statistics`; | ||
| }; | ||
|
|
||
| const capacityURL = getCapacityURL(network); |
xmonader
reviewed
Jun 4, 2023
|
|
||
| const capacityURL = getCapacityURL(network); | ||
|
|
||
| export default capacityURL; |
There was a problem hiding this comment.
the exported should be the getCapacityURL function, this variable capacityURL shouldn't exist, it needs to only exist at the caller frame
Mahmoud-Emad
approved these changes
Jun 4, 2023
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist