Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync display data on dedicated nodes table with node explorer #503

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Sync display data on dedicated nodes table with node explorer #503

merged 5 commits into from
Jun 8, 2023

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jun 8, 2023 •
edited
Loading

Description

Make the dedicated nodes table display the data as the explorer table.

  • now dedicated nodes table
    image
  • the explorer
    image

Changes

  • change the order to cru, mru, sru, hru in both tables
  • set the values to be Fixed(2)
  • set HRU to be in TB

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R 0oM4R added the dashboard label Jun 8, 2023
@0oM4R 0oM4R changed the title Development dashboard dedicated nodes table Sync display data on dedicated nodes table with node explorer Jun 8, 2023
@0oM4R 0oM4R mentioned this pull request Jun 8, 2023
Closed
AhmedHanafy725
AhmedHanafy725 requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order of the resources should be cru, mru, sru, hru in both tables

packages/dashboard/src/portal/components/NodesTable.vue Outdated
@@ -184,6 +184,10 @@ export default class NodesTable extends Vue {
byteToGB(capacity: number) {
return byteToGB(capacity);
}

byteToTB(capacity: number) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use this method for conversion to always has the same units for the both tables https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/dashboard/src/explorer/filters/toTeraOrGigaOrPeta.ts

AhmedHanafy725
AhmedHanafy725 requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order of the resources should be cru, mru, sru, hru in both tables

@0oM4R 0oM4R requested a review from AhmedHanafy725 June 8, 2023 13:40
@AhmedHanafy725 AhmedHanafy725 merged commit 7206ac9 into development Jun 8, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_dashboard_dedicatedNodesTable branch June 8, 2023 15:22
@0oM4R 0oM4R mentioned this pull request Jun 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0oM4R @AhmedHanafy725