Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disks page description, change deploy btn #549

Merged
merged 10 commits into from
Jun 15, 2023
Merged

Add disks page description, change deploy btn #549

merged 10 commits into from
Jun 15, 2023

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jun 12, 2023 •
edited
Loading

Changes

  • change style of add btn
  • add a description to disks page

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R 0oM4R marked this pull request as draft June 12, 2023 12:45
@0oM4R 0oM4R marked this pull request as ready for review June 12, 2023 13:54
xmonader
xmonader requested changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@xmonader xmonader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be bold, and the disk is that context is added to the virtual machine not the deployment, the user doesn't really know anything about the Deployment type itself

Please make the description

Add additional disk space to your virtual machine

@Mahmoud-Emad Mahmoud-Emad self-requested a review June 13, 2023 11:42
@0oM4R
Copy link
Contributor Author

0oM4R commented Jun 14, 2023

Please make the description

Add additional disk space to your virtual machine

we have full vm, and micro vm

the current change I made is

image
image

another point. should we have the same description for env section
Add environment variables to your Full virtual machine

@xmonader

@0oM4R 0oM4R requested a review from xmonader June 14, 2023 12:18
This was referenced Jun 14, 2023
Closed
Closed
@xmonader
Copy link
Contributor

There's no environment for full vms right?

@0oM4R
Copy link
Contributor Author

0oM4R commented Jun 15, 2023

There's no environment for full vms right?

yes micro vm only have it

@xmonader xmonader merged commit d5c7a26 into development Jun 15, 2023
@xmonader xmonader deleted the development_playground_enhance_UI branch June 15, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

Assignees
No one assigned
Labels
playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0oM4R @xmonader @Mahmoud-Emad