Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dynamic way to add info for required pages only #566

Merged
merged 13 commits into from
Jun 19, 2023
Merged

Add a dynamic way to add info for required pages only #566

merged 13 commits into from
Jun 19, 2023

Conversation

MohamedElmdary
Copy link
Member

Issues

Updates

  • Allow to add markdown pages indicates info about the page
  • Allow to change tooltip if needed (default: Show Details)
  • Allow to use {title, subtitle} as metadata in markdown (optional)
  • Accepting .md and .html (as markded.js js markdown parser supports both)

Preview

image
image
image
image

Note: An example is included for preview and should be replaced with the real data before merge PR

@MohamedElmdary MohamedElmdary marked this pull request as draft June 13, 2023 12:30
@xmonader xmonader mentioned this pull request Jun 15, 2023
Closed
@MohamedElmdary MohamedElmdary marked this pull request as ready for review June 18, 2023 10:01
@AhmedHanafy725
Copy link
Contributor

all workflows are failing

@AhmedHanafy725 AhmedHanafy725 merged commit 512cf83 into development Jun 19, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_support_markdown_info branch June 19, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohamedElmdary @AhmedHanafy725 @xmonader