Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development support tooltip #640

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Development support tooltip #640

merged 9 commits into from
Jun 19, 2023

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Jun 18, 2023 •
edited
Loading

Description

This pull request addresses several improvements related to tooltips and field descriptions in the network options of the playground.

Changes

  • Added an "i" icon next to the fields in the network options section to indicate the availability of additional information. This enhances the user experience by making it clear that tooltips are available for these fields.
  • Fixed the issue where the fields' sizes became uneven after adding the info icon, ensuring a visually balanced layout.

Related Issues

Screenshots

  • image
  • image
  • image

Update Screenshots

  • image

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft June 19, 2023 06:38
@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review June 19, 2023 09:44
@zaelgohary zaelgohary mentioned this pull request Jun 19, 2023
Closed
AhmedHanafy725
AhmedHanafy725 requested changes Jun 19, 2023
View reviewed changes
packages/playground/src/components/caprover_worker.vue Outdated Show resolved Hide resolved
packages/playground/src/components/k8s_worker.vue Outdated Show resolved Hide resolved
packages/playground/src/components/select_gateway_node.vue Outdated Show resolved Hide resolved
packages/playground/src/components/select_gateway_node.vue Outdated Show resolved Hide resolved
packages/playground/src/components/select_solution_flavor.vue Outdated Show resolved Hide resolved
packages/playground/src/components/select_vm_image.vue Outdated Show resolved Hide resolved
packages/playground/src/components/select_vm_image.vue Outdated Show resolved Hide resolved
packages/playground/src/components/smtp_server.vue Outdated Show resolved Hide resolved
packages/playground/src/weblets/tf_algorand.vue Outdated Show resolved Hide resolved
@AhmedHanafy725 AhmedHanafy725 merged commit 1dd97fd into development Jun 19, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_support_tooltip branch June 19, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mahmoud-Emad @AhmedHanafy725