update tests workflow node version #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Harby
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
mohamedamer453
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
I ran the 3 workflows against this branch. and the node installation step passed without any issues.
https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/5320516559/jobs/9634394921#step:3:1
https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/5320529511/jobs/9634424931#step:5:1
https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/5320494202/jobs/9634342081#step:6:1
AhmedHanafy725
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update node version from 16 to 18 in the tests workflow.