add custom packages for Full VM && Micro VM #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaaElattar
requested review from
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
|
Full VM |
packages/playground/src/components/select_solution_flavor_ssd.vue
Outdated
Show resolved
Hide resolved
|
please resolve the conflicts |
|
the workflows are failing, can you check? |
Comment on lines
69
to
70
| minimum: { type: Object as Package, default: () => ({ cpu: 1, memory: 1024 * 2, ssd: 15 }) }, | ||
| standard: { type: Object as Package, default: () => ({ cpu: 2, memory: 1024 * 2, ssd: 100 }) }, |
There was a problem hiding this comment.
Suggested change
| minimum: { type: Object as Package, default: () => ({ cpu: 1, memory: 1024 * 2, ssd: 15 }) }, | |
| standard: { type: Object as Package, default: () => ({ cpu: 2, memory: 1024 * 2, ssd: 100 }) }, | |
| minimum: { type: Object as Package, default: () => ({ cpu: 1, memory: 1024 * 2, disk: 15 }) }, | |
| standard: { type: Object as Package, default: () => ({ cpu: 2, memory: 1024 * 2, disk: 100 }) }, |
Why did we update disk to ssd here?
There was a problem hiding this comment.
It was thabet's request. @xmonader
There was a problem hiding this comment.
it can be internally defined as disk, but to the user it should be shown as SSD Storage or SSD Disk
| recommended: { | ||
| type: Object as Package, | ||
| default: () => ({ cpu: 4, memory: 1024 * 4, disk: 250 }), | ||
| default: () => ({ cpu: 4, memory: 1024 * 4, ssd: 250 }), |
There was a problem hiding this comment.
Suggested change
| default: () => ({ cpu: 4, memory: 1024 * 4, ssd: 250 }), | |
| default: () => ({ cpu: 4, memory: 1024 * 4, disk: 250 }), |
Same here
0oM4R
requested changes
Jul 20, 2023
0oM4R
requested changes
Jul 24, 2023
| :cpu="cpu" | ||
| :memory="memory" | ||
| :cpu="solution?.cpu" | ||
| :memory="solution?.memory" | ||
| :disk="disks.reduce((total, disk) => total + disk.size, rootFsSize)" |
There was a problem hiding this comment.
update the disk here to be consistence with the solution disk :
after logging the filters i see the value is only 2 <the init value of rootFsSize
0oM4R
reviewed
Jul 25, 2023
0oM4R
approved these changes
Jul 26, 2023
AhmedHanafy725
approved these changes
Jul 27, 2023
AlaaElattar
added a commit
that referenced
this pull request
Jul 31, 2023
* add custom packages for fullvm * remove select_resources component * add micro vm packages * update disk in component to ssd storage * check workflow * fix lint workflow * fix linting * fix disk prop * fix filters update * fix disk issue in micro vm * remove unnecessary value * update disks in machine model * return line removed by mistake * add solution disk to rootfs * remove rootfs * remove rootfs component --------- Co-authored-by: kassem <omarksm09@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.