Disable updateSSH on low balance #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
requested review from
AhmedHanafy725,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
| @@ -271,7 +271,7 @@ | |||
| color="primary" | |||
| variant="text" | |||
| @click="updateSSH" | |||
| :disabled="!ssh || profileManager.profile.ssh === ssh || updatingSSH" | |||
| :disabled="!ssh || profileManager.profile.ssh === ssh || updatingSSH || !isEnoughBalance(balance)" | |||
There was a problem hiding this comment.
Suggested change
| :disabled="!ssh || profileManager.profile.ssh === ssh || updatingSSH || !isEnoughBalance(balance)" | |
| :disabled="!ssh || profileManager.profile.ssh === ssh || updatingSSH || !isEnoughBalance(balance, 0.001)" |
Please update isEnoughBalance to take the balance and the amount to check for because right now no idea what is the enough balance without digging into isEnoughBalance ...
There was a problem hiding this comment.
Wouldn't that leave room for error if the second param does not equal the lowest possible balance? The minimum balance should be the same in all cases and the suggested fix won't ensure that.
There was a problem hiding this comment.
Added a minimum amount by default in isEnoughBalance.
MohamedElmdary
approved these changes
Jun 25, 2023
AhmedHanafy725
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable updateSSH on low balance
Related Issues
Generate ssh keyis not disabled for an account that doesn't have enough tfts #322Checklist