Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set & get dedicated node extra fees in chain & client #698

Merged
merged 11 commits into from
Jun 22, 2023
Merged

Add set & get dedicated node extra fees in chain & client #698

merged 11 commits into from
Jun 22, 2023

Conversation

zaelgohary
Copy link
Contributor

Description

  • Added setExtraFees & getDedicatedNodePrice
  • Added extraFees script
  • removed unnecessary awaits

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as draft June 21, 2023 13:33
AhmedHanafy725
AhmedHanafy725 requested changes Jun 21, 2023
View reviewed changes
packages/tfchain_client/src/contracts.ts Outdated Show resolved Hide resolved
packages/tfchain_client/src/nodes.ts Outdated Show resolved Hide resolved
packages/tfchain_client/src/nodes.ts Outdated Show resolved Hide resolved
@zaelgohary zaelgohary marked this pull request as ready for review June 21, 2023 14:07
@zaelgohary zaelgohary changed the title Add set & get dedicated node price in chain & client Add set & get dedicated node extra fees in chain & client Jun 21, 2023
@zaelgohary zaelgohary merged commit 09b0e28 into development Jun 22, 2023
@zaelgohary zaelgohary deleted the development_add_extra_fees branch June 22, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaelgohary @AhmedHanafy725