Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GPU section in explorer #725

Merged
merged 8 commits into from
Jun 26, 2023

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jun 26, 2023

Description

  • move all GPU-related logic to the GPUDetails component and use getNodeGPUs from portal/lib/nodes to fetch gpu details
  • add gpu loading indicator to gpu section
  • add error and retry btn to gpu section in case of failure
    Screenshot from 2023-06-26 14-53-53
Screencast.from.26.2023.EEST.12.07.45.webm

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R 0oM4R marked this pull request as ready for review June 26, 2023 12:12
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
@0oM4R 0oM4R merged commit 19c837c into development Jun 26, 2023
@0oM4R 0oM4R deleted the development_dashboard_GPUEroor_explorer branch June 26, 2023 12:47
AlaaElattar pushed a commit that referenced this pull request Jul 31, 2023
* method to reload

* add loading

* move fetch gpu to gpu details

* add details to loading

* enhance loading

* remove align class

* rephrase error message

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

---------

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants