Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search capabilities in dedicated nodes page #730

Merged
merged 15 commits into from
Jul 20, 2023
Merged

Add search capabilities in dedicated nodes page #730

merged 15 commits into from
Jul 20, 2023

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Jun 26, 2023 •
edited
Loading

Description

Created a new layout component for the new dedicated nodes view, added action/mutation type, and added a watcher on the search input value change to request the grid proxy with the new value.

Changes

  • Created mutation and used It instead of hard-coded
  • add dedicatedNodes, dedicatedNodesFilter, dedicatedNodesTablePageSize, dedicatedNodesTablePageNumber and dedicatedNodesCount fields inside the PortalState point to the dedicated nodes view.
  • Created a layout for the dedicated nodes page
  • Support filter nodes inside the dedicated nodes view

Supported keys

  • CPU
  • memory
  • SSD disk
  • HDD disk
  • GPU's vendor name
  • GPU's vendor id
  • GPU's device name
  • GPU's device id

Related Issues

Screens

  • image

  • image

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
Created new layout component for the new dedicated nodes view, added …
ba051fa 
…action/mutation type, added a watcher on the search input value change to request the grid proxy with the new value.
@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft June 26, 2023 14:02
@Mahmoud-Emad Mahmoud-Emad force-pushed the development_dedicated_nodes_search branch from 9a49685 to c72f145 Compare July 2, 2023 08:51
@Mahmoud-Emad
WIP: update the INode model with the missing fields, make a bind on t…
c0fb8b4 
…he inputes and request to get the nodes on change.
@Mahmoud-Emad
Merge branch 'development' into development_dedicated_nodes_search
1c8f1d7
@Mahmoud-Emad
WIP: Can search on dedicated nodes with the requested keys, aslo on t…
95e65f4 
…ab change can re-request to get the nodes based on the tab query, some improvement needed
@Mahmoud-Emad
WIP: Added some improvements on the dedicated nodes component and por…
88e58f6 
…tal actions/mutations files.
@Mahmoud-Emad
WIP: Fix dao issue.
f973e00
@Mahmoud-Emad
WIP: Close the model in case the filter inputes is clicked.
3476056
@Mahmoud-Emad
WIP: Removed unused variables.
86b4156
@Mahmoud-Emad
WIP: Added unknown type inside the portalStore.
b22ed38
@Mahmoud-Emad
Merge branch 'development' into development_dedicated_nodes_search
84d7c0d
@Mahmoud-Emad
Added the GPU vendor/device filter, added mutation to delete the filt…
c9002f9 
…er key on destroy
@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review July 19, 2023 10:03
@Mahmoud-Emad Mahmoud-Emad mentioned this pull request Jul 19, 2023
Closed
zaelgohary
zaelgohary requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the nodes table is not shown completely although there's enough space around it. I think it would be better to remove/reduce the space in order for the table to be shown completely.

image

zaelgohary
zaelgohary requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor ID & Device ID are not shown in the table so I think it's safe to remove them from the filters.

image

zaelgohary
zaelgohary reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I filter by exisiting MRU value, some elligible nodes disappears.

image

image

@Mahmoud-Emad
Copy link
Contributor Author

Mahmoud-Emad commented Jul 20, 2023 •
edited
Loading

When I filter by exisiting MRU value, some elligible nodes disappears.

image

image

The proxy returned the data as seen here. However, please note that the values displayed in the node table represent the total, not the free capacity see here.

@Mahmoud-Emad
Copy link
Contributor Author

I noticed the nodes table is not shown completely although there's enough space around it. I think it would be better to remove/reduce the space in order for the table to be shown completely.

image

image

image

Please take a look again.

@Mahmoud-Emad Mahmoud-Emad force-pushed the development_dedicated_nodes_search branch from 980e101 to 00e5a8b Compare July 20, 2023 08:07
@AhmedHanafy725
Copy link
Contributor

AhmedHanafy725 commented Jul 20, 2023 •
edited
Loading

I don't think we need to have free filters here, the user is going to rent the whole node so he only cares about filtering them by the total resources of the node.

@Mahmoud-Emad Mahmoud-Emad force-pushed the development_dedicated_nodes_search branch from 3da4153 to eedd4b3 Compare July 20, 2023 09:11
@Mahmoud-Emad Mahmoud-Emad force-pushed the development_dedicated_nodes_search branch from eedd4b3 to 9b1e084 Compare July 20, 2023 09:16
@Mahmoud-Emad Mahmoud-Emad merged commit 840c3d6 into development Jul 20, 2023
@Mahmoud-Emad Mahmoud-Emad deleted the development_dedicated_nodes_search branch July 20, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mahmoud-Emad @AhmedHanafy725 @zaelgohary