Dashboard: Enhance UX in connect polkadot page #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0oM4R
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
Mahmoud-Emad
requested changes
Jul 3, 2023
Mahmoud-Emad
approved these changes
Jul 3, 2023
AlaaElattar
pushed a commit
that referenced
this pull request
Jul 31, 2023
* show error messages, set a delay before readying the accounts data * show error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
user needs to know what happened, clicking on the connect button has no effect for the user in some cases.
1- if the extension is not enabled or the user is not allowed access to the website
2- if the extension has no registered accounts
Changes
1- check on the enabled extensions returned by
web3Enablefunction, and show an error message if the length is 0;2- check on the subscribed accounts in the store, this needs to be done after a delay (50ms) works fine with me
Screencast.from.03.2023.EEST.11.36.28.webm
Screencast.from.03.2023.EEST.11.49.10.webm
Related Issues
Checklist